Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YUNIKORN-2180] Clean up scheduler state initialization #734

Closed
wants to merge 2 commits into from
Closed

[YUNIKORN-2180] Clean up scheduler state initialization #734

wants to merge 2 commits into from

Conversation

craigcondit
Copy link
Contributor

@craigcondit craigcondit commented Nov 22, 2023 •
edited
Loading

  • Moved all state initialization code into context
  • Unified primary and secondary scheduler caches
  • Properly handle orphaned pods (those referring to unknown nodes)

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2180

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@craigcondit craigcondit self-assigned this Nov 22, 2023
@craigcondit craigcondit force-pushed the YUNIKORN-2180 branch 4 times, most recently from 18442b0 to 9c3a6a0 Compare November 22, 2023 20:33
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2023 •
edited
Loading

Codecov Report

Attention: 242 lines in your changes are missing coverage. Please review.

Comparison is base (9d303ad) 69.52% compared to head (22990af) 71.27%.
Report is 2 commits behind head on master.

Files Patch % Lines
pkg/cache/context.go 62.35% 159 Missing and 39 partials ⚠️
pkg/cache/scheduler_callback.go 0.00% 10 Missing ⚠️
pkg/cache/node_events.go 0.00% 8 Missing ⚠️
pkg/cache/task.go 80.95% 6 Missing and 2 partials ⚠️
pkg/shim/scheduler.go 50.00% 4 Missing and 2 partials ⚠️
pkg/dispatcher/dispatcher.go 82.75% 5 Missing ⚠️
pkg/cache/application.go 55.55% 3 Missing and 1 partial ⚠️
pkg/cache/external/scheduler_cache.go 97.58% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   69.52%   71.27%   +1.75%     
==========================================
  Files          50       43       -7     
  Lines        7990     7600     -390     
==========================================
- Hits         5555     5417     -138     
+ Misses       2247     1981     -266     
- Partials      188      202      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@craigcondit craigcondit force-pushed the YUNIKORN-2180 branch 13 times, most recently from 1bd56aa to a5f3748 Compare December 13, 2023 20:55
@craigcondit craigcondit force-pushed the YUNIKORN-2180 branch 2 times, most recently from b4b9d72 to a98d09b Compare December 18, 2023 22:47
@craigcondit craigcondit changed the title [WIP] [YUNIKORN-2180] Clean up scheduler state initialization [YUNIKORN-2180] Clean up scheduler state initialization Dec 18, 2023
@craigcondit craigcondit force-pushed the YUNIKORN-2180 branch 4 times, most recently from d894f76 to 5091dea Compare December 19, 2023 23:36
@craigcondit craigcondit marked this pull request as ready for review December 20, 2023 17:35
This was referenced Dec 20, 2023
Closed
Closed
@craigcondit
[YUNIKORN-2180] Clean up scheduler state initialization
4ace8ce 
- Moved all state initialization code into context
- Unified primary and secondary scheduler caches
- Properly handle orphaned pods (those referring to unknown nodes)
@craigcondit
Copy link
Contributor Author

Rebased code after merge of YUNIKORN-2282.

pbacsko
pbacsko requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, I only found some minor things.

pkg/cache/context.go Show resolved Hide resolved
pkg/cache/context.go Show resolved Hide resolved
pkg/cache/context.go Show resolved Hide resolved
pkg/cache/external/scheduler_cache.go Show resolved Hide resolved
@craigcondit craigcondit requested a review from pbacsko January 4, 2024 16:30
pbacsko
pbacsko approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@pbacsko pbacsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@craigcondit craigcondit deleted the YUNIKORN-2180 branch January 5, 2024 14:55
chenyulin0719 pushed a commit to chenyulin0719/yunikorn-k8shim that referenced this pull request Jan 9, 2024
@craigcondit @chenyulin0719
[YUNIKORN-2180] Clean up scheduler state initialization (apache#734)
389f916 
- Moved all state initialization code into context
- Unified primary and secondary scheduler caches
- Properly handle orphaned pods (those referring to unknown nodes)

Closes: apache#734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbacsko pbacsko pbacsko approved these changes

@manirajv06 manirajv06 Awaiting requested review from manirajv06

@wilfred-s wilfred-s Awaiting requested review from wilfred-s

Assignees

@craigcondit craigcondit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@craigcondit @pbacsko